Adding pubsub routing support#631
Merged
Merged
Conversation
artursouza
suggested changes
Sep 17, 2021
artursouza
left a comment
artursouza
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall. Just some minor comments.
|
ping @pkedy |
Contributor
|
This PR is idle and available to anyone that would like to take over and then create a new PR to replace this one. |
artursouza
force-pushed
the
pubsub_routing
branch
2 times, most recently
from
dd9e31e to
b7a858f
Compare
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* remove deprecated classes Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * remove builder class ref in ITs Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * fix setter in IT Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
artursouza
force-pushed
the
pubsub_routing
branch
3 times, most recently
from
016fafd to
fe9d4c7
Compare
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
artursouza
force-pushed
the
pubsub_routing
branch
from
fe9d4c7 to
18f5b45
Compare
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
============================================
- Coverage 78.19% 76.34% -1.86%
Complexity 1117 1117
============================================
Files 97 101 +4
Lines 3417 3500 +83
Branches 399 407 +8
============================================
Hits 2672 2672
- Misses 547 630 +83
Partials 198 198
Continue to review full report at Codecov.
|
artursouza
approved these changes
Jun 23, 2022
naah69
pushed a commit
to naah69/dapr-java-sdk
that referenced
this pull request
Jul 7, 2022
* Adding pubsub routing support Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * remove deprecated classes (dapr#704) * remove deprecated classes Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * remove builder class ref in ITs Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * fix setter in IT Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Address PR comments. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: naah69 <nayan3480232@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a rule attribute to the topic annotation to utilize PubSub routing.
Issue reference
dapr/dapr#2582
Checklist