Skip to content

remove deprecated classes#704

Merged
artursouza merged 4 commits into
dapr:masterfrom
mukundansundar:remove-deprecated-classes
Mar 15, 2022
Merged

remove deprecated classes#704
artursouza merged 4 commits into
dapr:masterfrom
mukundansundar:remove-deprecated-classes

Conversation

@mukundansundar

@mukundansundar mukundansundar commented Mar 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Mukundan Sundararajan msundar.ms@outlook.com

Description

Removed classes deprecated in 1.3.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #601

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mukundansundar
remove deprecated classes
1595ff7 
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
@mukundansundar
remove builder class ref in ITs
de4fe54 
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
@mukundansundar
fix setter in IT
afd4b47 
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
@mukundansundar mukundansundar marked this pull request as ready for review March 15, 2022 06:46
@mukundansundar mukundansundar requested review from a team as code owners March 15, 2022 06:46
@mukundansundar

mukundansundar commented Mar 15, 2022

Copy link
Copy Markdown
Contributor Author

supersedes #607 ....

@codecov

codecov Bot commented Mar 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #704 (444e61b) into master (904dbe0) will increase coverage by 3.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #704      +/-   ##
============================================
+ Coverage     77.62%   80.66%   +3.04%     
  Complexity      993      993              
============================================
  Files            91       81      -10     
  Lines          3128     3010     -118     
  Branches        342      340       -2     
============================================
  Hits           2428     2428              
+ Misses          534      416     -118     
  Partials        166      166

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904dbe0...444e61b. Read the comment docs.

tanvigour
tanvigour approved these changes Mar 15, 2022
View reviewed changes

@tanvigour tanvigour left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artursouza artursouza merged commit 0b881d3 into dapr:master Mar 15, 2022
@mukundansundar mukundansundar deleted the remove-deprecated-classes branch March 15, 2022 18:19
DeepanshuA pushed a commit to DeepanshuA/java-sdk that referenced this pull request Mar 16, 2022
@mukundansundar @DeepanshuA
remove deprecated classes (dapr#704)
0325174 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 17, 2022
@mukundansundar
remove deprecated classes (dapr#704)
42f74bc 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
subash89 pushed a commit to subash89/java-sdk that referenced this pull request Mar 18, 2022
@mukundansundar @subashfmr
remove deprecated classes (dapr#704)
72d8cae 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: Subash Gamage <subash.hewawidanagamage@fmr.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
remove deprecated classes (dapr#704)
f682f5b 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
remove deprecated classes (dapr#704)
e6e68cb 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
remove deprecated classes (dapr#704)
36f1ec1 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
remove deprecated classes (dapr#704)
1f4daf1 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
remove deprecated classes (dapr#704)
f8cbd9a 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
remove deprecated classes (dapr#704)
df12bfa 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
@mukundansundar mukundansundar mentioned this pull request Jun 22, 2022
Closed
3 tasks
artursouza pushed a commit to pkedy/java-sdk that referenced this pull request Jun 22, 2022
@mukundansundar @artursouza
remove deprecated classes (dapr#704)
871fdc7 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
artursouza pushed a commit to pkedy/java-sdk that referenced this pull request Jun 22, 2022
@mukundansundar @artursouza
remove deprecated classes (dapr#704)
56304a4 
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
artursouza added a commit that referenced this pull request Jun 23, 2022
@pkedy @mukundansundar @artursouza
Adding pubsub routing support (#631)
2235e3d 
* Adding pubsub routing support

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* remove deprecated classes (#704)

* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Address PR comments.

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
naah69 pushed a commit to naah69/dapr-java-sdk that referenced this pull request Jul 7, 2022
@pkedy @mukundansundar
@artursouza @naah69
Adding pubsub routing support (dapr#631)
6358b27 
* Adding pubsub routing support

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* remove deprecated classes (dapr#704)

* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Address PR comments.

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@artursouza artursouza artursouza approved these changes
@tanvigour tanvigour tanvigour approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated builder classes

3 participants

@mukundansundar @artursouza @tanvigour