move privatesend rpc methods from rpc/masternode.cpp to new rpc/privatesend.cpp#3253
Merged
Merged
Conversation
Signed-off-by: Pasta <pasta@dashboost.org>
Signed-off-by: Pasta <pasta@dashboost.org>
Member
Author
|
(Hopefully) resolved the compilation errors when wallet is disabled. |
Signed-off-by: Pasta <pasta@dashboost.org>
codablock
reviewed
Dec 30, 2019
Signed-off-by: Pasta <pasta@dashboost.org>
|
Shouldn't this be merged in |
|
Hmm.. yeah, probably a good idea. Should remove conflicts for #3265 backport. |
Member
Author
|
Why should this be in 15? It doesn't affect anything, just a refactoring really |
|
@PastaPastaPasta just like with bitcoin backports it's better to keep them in order if this allows you to avoid merge conflicts and it's a trivial one so why not? |
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jan 10, 2020
…tesend.cpp (dashpay#3253) * move privatesend rpc methods from masternode.cpp to new privatesend.cpp Signed-off-by: Pasta <pasta@dashboost.org> * add ifdef ENABLE_WALLET check for wallet.h import Signed-off-by: Pasta <pasta@dashboost.org> * actually register privatesend rpc Signed-off-by: Pasta <pasta@dashboost.org> * add dropped help text and change some weird spacing below Signed-off-by: Pasta <pasta@dashboost.org>
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
…tesend.cpp (dashpay#3253) * move privatesend rpc methods from masternode.cpp to new privatesend.cpp Signed-off-by: Pasta <pasta@dashboost.org> * add ifdef ENABLE_WALLET check for wallet.h import Signed-off-by: Pasta <pasta@dashboost.org> * actually register privatesend rpc Signed-off-by: Pasta <pasta@dashboost.org> * add dropped help text and change some weird spacing below Signed-off-by: Pasta <pasta@dashboost.org> Signed-off-by: cevap <dev@i2pmail.org>
cryptolinux
pushed a commit
to cryptolinux/ion
that referenced
this pull request
Feb 6, 2021
…tesend.cpp (dashpay#3253) * move privatesend rpc methods from masternode.cpp to new privatesend.cpp Signed-off-by: Pasta <pasta@dashboost.org> * add ifdef ENABLE_WALLET check for wallet.h import Signed-off-by: Pasta <pasta@dashboost.org> * actually register privatesend rpc Signed-off-by: Pasta <pasta@dashboost.org> * add dropped help text and change some weird spacing below Signed-off-by: Pasta <pasta@dashboost.org> Signed-off-by: cevap <dev@i2pmail.org>
ckti
pushed a commit
to ckti-gitian-ion/ion
that referenced
this pull request
Mar 29, 2021
…tesend.cpp (dashpay#3253) * move privatesend rpc methods from masternode.cpp to new privatesend.cpp Signed-off-by: Pasta <pasta@dashboost.org> * add ifdef ENABLE_WALLET check for wallet.h import Signed-off-by: Pasta <pasta@dashboost.org> * actually register privatesend rpc Signed-off-by: Pasta <pasta@dashboost.org> * add dropped help text and change some weird spacing below Signed-off-by: Pasta <pasta@dashboost.org> Signed-off-by: cevap <dev@i2pmail.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't really make sense imo for those rpc commands to be in masternode.cpp.
Should be just a move only and then adjusting imports