Tweak few more strings re mixing and balances#3265
Merged
Conversation
PastaPastaPasta
requested changes
Jan 2, 2020
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
NACK, I do not like the phrase "fully mixed" I would be happy with "partially mixed" contrasting with "mixed" but I do not think "fully mixed" is a good phrase.
Author
|
How about replacing it with simply "PrivateSend" (and tweaking strings accordingly in rpc and options)? pinging @strophy |
|
I would support using "PrivateSend balance" as a replacement for "fully mixed". I would suggest removing the definite article from "The desirable PrivateSend balance in DASH", maybe something more like "Target PrivateSend balance" is sufficient? |
PastaPastaPasta
requested changes
Jan 2, 2020
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
These are my thoughts
Co-Authored-By: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Jan 10, 2020
* Tweak few more strings re mixing and balances * "Fully mixed"/"mixed" -> "PrivateSend" * Apply suggestions from code review Co-Authored-By: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
* Tweak few more strings re mixing and balances * "Fully mixed"/"mixed" -> "PrivateSend" * Apply suggestions from code review Co-Authored-By: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Signed-off-by: cevap <dev@i2pmail.org>
cryptolinux
pushed a commit
to cryptolinux/ion
that referenced
this pull request
Feb 6, 2021
* Tweak few more strings re mixing and balances * "Fully mixed"/"mixed" -> "PrivateSend" * Apply suggestions from code review Co-Authored-By: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Signed-off-by: cevap <dev@i2pmail.org>
ckti
pushed a commit
to ckti-gitian-ion/ion
that referenced
this pull request
Mar 29, 2021
* Tweak few more strings re mixing and balances * "Fully mixed"/"mixed" -> "PrivateSend" * Apply suggestions from code review Co-Authored-By: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Signed-off-by: cevap <dev@i2pmail.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up for #3211