Skip to content

depends: Add sodium to depends#4174

Closed
UdjinM6 wants to merge 1 commit into
dashpay:developfrom
UdjinM6:add_sodium
Closed

depends: Add sodium to depends#4174
UdjinM6 wants to merge 1 commit into
dashpay:developfrom
UdjinM6:add_sodium

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented May 22, 2021

Copy link
Copy Markdown

Should probably fix #4168

@UdjinM6 UdjinM6 added this to the 17.1 milestone May 22, 2021
@UdjinM6
UdjinM6 marked this pull request as ready for review May 22, 2021 23:40

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6

UdjinM6 commented May 24, 2021

Copy link
Copy Markdown
Author

Closing in fav of #4176

@UdjinM6 UdjinM6 closed this May 24, 2021
@UdjinM6 UdjinM6 removed this from the 17.1 milestone May 24, 2021
@zikarad

zikarad commented May 25, 2021

Copy link
Copy Markdown

Could hash of libsodium-1.0.18-stable.tar.gz be reviewed?
I can see this sha256sum:
32be348b1b7f5dd7bb890f2c867351ece5d478a3e7d2d324cbfd4aa261e71317 libsodium-1.0.18-stable.tar.gz
instead of
3c240fcd414189492d7c7dc12d2cf48f67bf04142ce2f60b620adb5bac6ca732

@UdjinM6

UdjinM6 commented May 25, 2021

Copy link
Copy Markdown
Author

libsodium-x.y.z-stable.tar.gz is the source code of x.y.z with bug fixes, security fixes and minor improvements immediately backported from the next version being currently in development. These additions over the point release are guaranteed to never change the behavior or API. Version x.y.z-stable is always fully compatible with version x.y.z. New features or breaking changes will never be introduced in a stable set of changes. libsodium-x.y.z-stable.tar.gz is an automated daily copy of the stable branch in the Git repository.

https://download.libsodium.org/libsodium/releases/README.html

Another reason why #4176 is a better solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants