depends: Undefine BLSALLOC_SODIUM in bls-dash.mk#4176
Merged
PastaPastaPasta merged 1 commit intoMay 25, 2021
Conversation
UdjinM6
approved these changes
May 24, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Seems to be working for me on a fresh new node with libsodium-dev installed 👍
ACK
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 3, 2021
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jul 1, 2021
celbalrai
pushed a commit
to bytzcurrency/BYTZ
that referenced
this pull request
Jul 15, 2021
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets set if
libsodiumgets located bycmakeinbls-signatures, see https://github.com/dashpay/bls-signatures/blob/main/CMakeLists.txt#L35 which leads to sodium being used here https://github.com/dashpay/bls-signatures/blob/main/src/bls.cpp#L47-L50 and that obviously leads to mixing shared/static libs like in #4168.This is meant to be an replacement for #4174.