chore: updates needed for compatibility with nfts in the tui - #1833
Merged
Conversation
|
Does this affect Dash Platform stability testing (iaw your guide), through use of Platform TUI ? Should we wait on the merger of this pull request ? Edit : or is the relevant part possibly affecting Platform stability testing already merged through pull request 1832 ? |
Member
Author
@qwizzie this will just allow for the NFT-related state transitions to be used in the TUI, both in the strategy tests once I add them, and also just in the Contracts screen. |
QuantumExplorer
requested changes
May 9, 2024
QuantumExplorer
approved these changes
May 9, 2024
QuantumExplorer
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Some files of the SDK were not public so they couldn't be accessed from the TUI where they are needed.
I also derived Serialize and Deserialize for the Index struct because I need to serialize the data contract indexes in order to display them in the TUI.
I also changed an error message to display more info, and made it a String instead of a str. The rest of the error messages should be changed to a String as well in a separate PR (#1839)
What was done?
See above.
How Has This Been Tested?
Works in the TUI and passes tests
Breaking Changes
Checklist:
For repository code-owners and collaborators only