Skip to content

refactor(drive): change error messages to String - #1839

Closed
pauldelucia wants to merge 161 commits into
masterfrom
feat/change-drive-error-messages-to-strings
Closed

refactor(drive): change error messages to String#1839
pauldelucia wants to merge 161 commits into
masterfrom
feat/change-drive-error-messages-to-strings

Conversation

@pauldelucia

@pauldelucia pauldelucia commented May 7, 2024

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Change all the error messages in rs-drive from str to String

What was done?

Change all the error messages in rs-drive from str to String

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek and others added 30 commits November 27, 2023 12:53
@lklimek
chore: automatic clippy fixes (#1528)
5b4e232
@lklimek
chore: cargo clippy fixes, continued (#1602)
28820ae
@lklimek
feat(sdk): rs-sdk fetch current epoch (#1604)
13243e9
@shumkov
Merge branch 'master' into v1.0-dev
f801f61
@QuantumExplorer
Merge branch 'master' into v1.0-dev
5bd7a58
@QuantumExplorer
feat(drive-abci)!: processing fees for signature verification (#1656)
becabaf
@QuantumExplorer @shumkov
fix(platform)!: credit transfer replay attack (#1634)
d177116 
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@shumkov
feat(drive-abci)!: include invalid state transitions into block (#1657)
ea27d6a
@QuantumExplorer @shumkov
feat(drive-abci)!: remove unnecessary validation from check tx and re…
c47aed4 
…-check (#1647)

Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@shumkov
fix(dapi): internal error when mempool is full (#1661)
8ad118f
@shumkov
chore(release): update change log and versions to 1.0.0-dev.1 (#1662)
c9b2927
@shumkov
chore(drive-abci): fix state transition logging (#1664)
9b24a19
@shumkov @QuantumExplorer
fix(drive-abci)!: internal error if vote extension block is already c…
49586bf 
…ommitted (#1663)

Co-authored-by: Quantum Explorer <quantum@dash.org>
@shumkov
fix: broadcasting already invalidated transitions (#1668)
f21ea2f
@shumkov @QuantumExplorer
chore: various logging improvements (#1666)
b3f0114 
Co-authored-by: QuantumExplorer <quantum@dash.org>
@shumkov
chore(dashmate)!: adjust consensus params and enable re-check (#1669)
31f84e4
@shumkov
fix(dashmate): dapi kills host machine on container stop (#1670)
d320578
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.2 (#1671)
535429a
@shumkov
fix(dapi): internal errors if broadcasting failed (#1673)
77febff
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.3 (#1674)
2c0c579
Igor Markin
chore(dashmate): update to core v20.1.0-devpr5806.a1814ce2 (#1665)
f8c88f3
Igor Markin @QuantumExplorer
feat(drive): validate asset lock proof minimal value (#1667)
30929ea 
Co-authored-by: QuantumExplorer <quantum@dash.org>
@shumkov
fix(drive): invalid protocol version is using to deserialize state (#…
26e775f 
…1679)
@QuantumExplorer @ogabrielides @shumkov
feat!: chainlock optimized verification (#1621)
20b39d6 
Co-authored-by: Odysseas Gabrielides <odysseas.gabrielides@gmail.com>
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@shumkov
chore: system data contracts versioning (#1676)
6b8df26
@pshenmic
fix(dashmate): service status when tenderdash is syncing (#1682)
0e78075
@lklimek
chore: update rs-tenderdash-abci to v0.14.0-dev.6 and tenderdash to v…
63e5366 
…0.14.0-dev.2 (#1686)
Igor Markin @ogabrielides @shumkov
feat(drive): withdrawals finalization (#1601)
9591752 
Co-authored-by: Odysseas Gabrielides <odysseas.gabrielides@gmail.com>
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.4 (#1688)
bf8e7b4
@QuantumExplorer
refactor(platform): autogenerated clippy fixes for rust version 1.76 (#…
7fc1cd9 
…1691)
pauldelucia and others added 24 commits April 13, 2024 09:37
@pauldelucia
feat: register init contracts on second block of strategy (#1808)
60ac47d
@QuantumExplorer
chore: update tenderdash-abci
e17ecfe
@lklimek
feat(sdk): reuse dapi connections (#1815)
8a61c85
@lklimek
refactor(sdk)!: rename crate rs-sdk to dash-sdk (#1811)
aca3ab5
@QuantumExplorer
feat(platform): query any element in Platform state (#1816)
f553b70
@lklimek
fix(sdk): dapi client pool should separate platform and core clients (#…
56a4d88 
…1818)
@QuantumExplorer
feat(platform)!: identity create replay protection (#1819)
fa72ffe
@QuantumExplorer
fix(platform)!: a withdrawal failure from core should never cause pla…
36a7dcc 
…tform to stop (#1821)
@QuantumExplorer
chore: bump to dev.11 (#1822)
5d51032
@lklimek
feat(drive-abci): configure dir to store rejected txs (#1823)
dde03fc
@shumkov
chore(dapi): update autogenerated clients (#1827)
2a5aac3
@QuantumExplorer
feat(platform)!: ability to transfer documents (#1826)
e71f92c
@HashEngineering
fix: add tls-webpki-roots to support tls on mobile (Android, iOS) (#1828
1c9c669 
)
Igor Markin
feat(dapi)!: split getStatus into two endpoints (#1812)
5404679
Igor Markin @QuantumExplorer
feat(sdk): add query for data contract history (#1787)
0b4a733 
Co-authored-by: Quantum Explorer <quantum@dash.org>
@QuantumExplorer
feat(platform)!: basic nft support (#1829)
377087b
Igor Markin
feat(wallet-lib): optional sync of the account (#1830)
122bbb9
@shumkov
chore(dashmate): limit concurrent state transition checks (#1824)
2a331c1
Igor Markin @QuantumExplorer
feat!: getIdentitiesContractKeys endpoint (#1766)
cfdc7dd 
Co-authored-by: Quantum Explorer <quantum@dash.org>
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.12 (#1831
6de96cd 
)
@pauldelucia
feat: make sdk document purchases public (#1832)
4ea0310
@pshenmic
fix(platform): npm audit security fix (#1836)
5612b31
@pshenmic
feat(dashmate): handle docker pull error on images update (#1685)
8073c3f
@pauldelucia
change query error messages to String
0ec0bbd
@pauldelucia pauldelucia mentioned this pull request May 7, 2024
Merged
6 tasks
@shumkov shumkov changed the title chore(drive): change error messages to String refactor(drive): change error messages to String May 13, 2024
shumkov
shumkov reviewed May 13, 2024
View reviewed changes
Comment thread packages/rs-drive/src/drive/document/query/mod.rs
)?
.ok_or(Error::Query(QuerySyntaxError::DataContractNotFound(
"contract not found",
"contract not found".to_string(),

@shumkov shumkov May 13, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use https://docs.rs/thiserror-ext/latest/thiserror_ext/derive.Construct.html so you can pass both Strings and &str to constructors

@shumkov
shumkov changed the base branch from v1.0-dev to master August 25, 2024 06:05
@pauldelucia
pauldelucia deleted the feat/change-drive-error-messages-to-strings branch September 12, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkov shumkov shumkov left review comments
@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer will be requested when the pull request is marked ready for review QuantumExplorer is a code owner
@lklimek lklimek Awaiting requested review from lklimek lklimek will be requested when the pull request is marked ready for review lklimek is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@pauldelucia @shumkov @lklimek @QuantumExplorer @pshenmic @fominok @PastaPastaPasta @thephez @HashEngineering