Skip to content

feat(drive): do not switch to validator quorum which will be removed soon#616

Merged
shuplenkov merged 46 commits into
v0.24-devfrom
filter-by-ttl
Jan 10, 2023
Merged

feat(drive): do not switch to validator quorum which will be removed soon#616
shuplenkov merged 46 commits into
v0.24-devfrom
filter-by-ttl

Conversation

@shuplenkov

@shuplenkov shuplenkov commented Nov 8, 2022

Copy link
Copy Markdown

Issue being fixed or feature implemented

Do not switch to validator quorum which will be removed soon

What was done?

Changed Drive's validator rotation logic

How Has This Been Tested?

With tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Nov 8, 2022
Konstantin Shuplenkov added 2 commits November 8, 2022 22:44
Comment thread packages/js-drive/lib/validator/ValidatorSet.js Outdated
Konstantin Shuplenkov added 4 commits November 9, 2022 16:39
@shuplenkov
shuplenkov marked this pull request as ready for review November 10, 2022 08:54
@shuplenkov
shuplenkov requested a review from antouhou as a code owner November 10, 2022 08:54

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wait for new RPC method from Core guys

@shuplenkov
shuplenkov marked this pull request as draft December 1, 2022 15:36
Konstantin Shuplenkov added 3 commits December 6, 2022 20:35
@shuplenkov
shuplenkov marked this pull request as ready for review December 7, 2022 15:45
Comment thread packages/js-drive/lib/core/getRandomQuorumFactory.js Outdated
Konstantin Shuplenkov added 14 commits December 8, 2022 12:16
# Conflicts:
#	packages/dashmate/configs/system/base.js
#	packages/rs-drive/Cargo.toml
# Conflicts:
#	.pnp.cjs
#	packages/dapi/package.json
#	packages/dashmate/configs/system/base.js
#	packages/dashmate/package.json
#	packages/dashmate/src/core/wallet/createNewAddress.js
#	packages/js-drive/package.json
#	yarn.lock
@shuplenkov
shuplenkov changed the base branch from v0.24-dev to feat/support-core December 29, 2022 13:55
@shuplenkov
shuplenkov changed the base branch from feat/support-core to v0.24-dev December 29, 2022 14:03
Konstantin Shuplenkov added 2 commits January 9, 2023 20:08
# Conflicts:
#	.pnp.cjs
#	packages/dapi/package.json
#	packages/dashmate/configs/system/base.js
#	packages/dashmate/package.json
#	packages/js-drive/package.json
#	yarn.lock

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov
shuplenkov merged commit d5d48c3 into v0.24-dev Jan 10, 2023
@shuplenkov
shuplenkov deleted the filter-by-ttl branch January 10, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants