feat(drive): do not switch to validator quorum which will be removed soon

packages/js-drive/lib/core/getRandomQuorumFactory.js

@@ -0,0 +1,108 @@
+const BufferWriter = require('@dashevo/dashcore-lib/lib/encoding/bufferwriter');
+const Hash = require('@dashevo/dashcore-lib/lib/crypto/hash');
+const QuorumsNotFoundError = require('./errors/QuorumsNotFoundError');
+const ValidatorSet = require('../validator/ValidatorSet');
+const llmqMap = require('./llmqMap');
+
+const MIN_QUORUM_VALID_MEMBERS = 90;
+
+/**
+ * Calculates scores for validator quorum selection
+ * it calculates sha256(hash, modifier) per quorumHash
+ * Please note that this is not a double-sha256 but a single-sha256
+ *
+ * @param {Buffer[]} quorumHashes
+ * @param {Buffer} modifier
+ * @return {Object[]} scores
+ */
+function calculateQuorumHashScores(quorumHashes, modifier) {
+  return quorumHashes.map((hash) => {
+    const bufferWriter = new BufferWriter();
+
+    bufferWriter.write(hash);
+    bufferWriter.write(modifier);
+
+    return { score: Hash.sha256(bufferWriter.toBuffer()), hash };
+  });
+}
+
+/**
+ *
+ * @param {RpcClient} coreRpcClient
+ * @return {getRandomQuorum}
+ */
+function getRandomQuorumFactory(coreRpcClient) {
+  /**
+   * Gets the current validator set quorum hash for a particular core height
+   *
+   * @typedef {getRandomQuorum}
+   * @param {SimplifiedMNList} sml
+   * @param {number} quorumType
+   * @param {Buffer} entropy - the entropy to select the quorum
+   * @param {number} coreHeight
+   * @return return {Promise<QuorumEntry>} - the current validator set's quorumHash
+   */
+  async function getRandomQuorum(sml, quorumType, entropy, coreHeight) {
+    const validatorQuorums = sml.getQuorumsOfType(quorumType);
+
+    if (validatorQuorums.length === 0) {
+      throw new QuorumsNotFoundError(sml, quorumType);
+    }
+
+    const { result: allValidatorQuorumsExtendedInfo } = await coreRpcClient.quorum('listextended', coreHeight);
+
+    // convert to object
+    const validatorQuorumsInfo = allValidatorQuorumsExtendedInfo[llmqMap[quorumType]]
+      .reduce(
+        (obj, item) => ({
+          ...obj,
+          ...item,
+        }),
+        {},
+      );
+
+    const numberOfQuorums = validatorQuorums.length;
+    const minTtl = ValidatorSet.ROTATION_BLOCK_INTERVAL * 3;
+    const dkgInterval = 24;
+
+    // filter quorum by the number of valid members to choose the most vital ones
+    let filteredValidatorQuorums = validatorQuorums
+      .filter(
+        (validatorQuorum) => validatorQuorum.validMembersCount >= MIN_QUORUM_VALID_MEMBERS,
+      )
+      .filter((validatorQuorum) => {
+        const validatorQuorumInfo = validatorQuorumsInfo[validatorQuorum.quorumHash];
+
+        if (!validatorQuorumInfo) {
+          return false;
+        }
+
+        const quorumRemoveHeight = validatorQuorumInfo.creationHeight
+          + (dkgInterval * numberOfQuorums);
+        const howMuchInRest = quorumRemoveHeight - coreHeight;
+        const quorumTtl = howMuchInRest * 2.5;
+
+        return quorumTtl > minTtl;
+      });
+
+    if (filteredValidatorQuorums.length === 0) {
+      // if there is no "vital" quorums, we choose among others with default min quorum size
+      filteredValidatorQuorums = validatorQuorums;
+    }
+
+    const validatorQuorumHashes = filteredValidatorQuorums
+      .map((quorum) => Buffer.from(quorum.quorumHash, 'hex'));
+
+    const scoredHashes = calculateQuorumHashScores(validatorQuorumHashes, entropy);
+
+    scoredHashes.sort((a, b) => Buffer.compare(a.score, b.score));
+
+    const quorumHash = scoredHashes[0].hash.toString('hex');
+
+    return sml.getQuorum(quorumType, quorumHash);
+  }
+
+  return getRandomQuorum;
+}
+
+module.exports = getRandomQuorumFactory;

packages/js-drive/lib/core/llmqMap.js

@@ -0,0 +1,25 @@
+module.exports = {
+  0xff: 'llmq_none',
+
+  1: 'llmq_50_60', // 50 members, 30 (60%) threshold, one per hour
+  2: 'llmq_400_60', // 400 members, 240 (60%) threshold, one every 12 hours
+  3: 'llmq_400_85', // 400 members, 340 (85%) threshold, one every 24 hours
+  4: 'llmq_100_67', // 100 members, 67 (67%) threshold, one per hour
+  5: 'llmq_60_75', // 60 members, 45 (75%) threshold, one every 12 hours
+
+  // for testing only
+  100: 'llmq_test', // 3 members, 2(66%) threshold, one per hour.
+
+  // for devnets only
+  101: 'llmq_devnet', // 12 members, 6 (50%) threshold, one per hour.
+
+  // for testing activation of new quorums only
+  102: 'llmq_test_v17', // 3 members, 2 (66%) threshold, one per hour.
+
+  // for testing only
+  103: 'llmq_test_dip0024', // 4 members, 2 (66%) threshold, one per hour.
+  104: 'llmq_test_instantsend', // 3 members, 2 (66%) threshold, one per hour.
+
+  // for devnets only. rotated version (v2) for devnets
+  105: 'llmq_devnet_dip0024', // 8 members, 4 (50%) threshold, one per hour.
+};

packages/js-drive/lib/createDIContainer.js

@@ -113,7 +113,7 @@ const getFeatureFlagForHeightFactory = require('./featureFlag/getFeatureFlagForH
 const ValidatorSet = require('./validator/ValidatorSet');
 const createValidatorSetUpdate = require('./abci/handlers/validator/createValidatorSetUpdate');
 const fetchQuorumMembersFactory = require('./core/fetchQuorumMembersFactory');
-const getRandomQuorum = require('./core/getRandomQuorum');
+const getRandomQuorumFactory = require('./core/getRandomQuorumFactory');
 const createQueryResponseFactory = require('./abci/handlers/query/response/createQueryResponseFactory');
 const BlockExecutionContextRepository = require('./blockExecution/BlockExecutionContextRepository');
 
@@ -350,8 +350,8 @@ function createDIContainer(options) {
     latestCoreChainLock: asValue(new LatestCoreChainLock()),
     simplifiedMasternodeList: asClass(SimplifiedMasternodeList).proxy().singleton(),
     fetchQuorumMembers: asFunction(fetchQuorumMembersFactory),
-    getRandomQuorum: asValue(getRandomQuorum),
     fetchSimplifiedMNList: asFunction(fetchSimplifiedMNListFactory),
+    getRandomQuorum: asFunction(getRandomQuorumFactory),
     coreZMQClient: asFunction((
       coreZMQHost,
       coreZMQPort,

packages/js-drive/lib/validator/ValidatorSet.js

@@ -110,6 +110,7 @@ class ValidatorSet {
       sml,
       this.validatorSetLLMQType,
       rotationEntropy,
+      coreHeight,
     );
 
     const quorumMembers = await this.fetchQuorumMembers(