feat(dashmate): high-performance nodes registration with setup command#794
Merged
Conversation
thephez
reviewed
Feb 21, 2023
thephez
left a comment
thephez
left a comment
Collaborator
There was a problem hiding this comment.
A couple suggestions (still looking at other stuff)
thephez
reviewed
Feb 21, 2023
thephez
reviewed
Feb 21, 2023
thephez
reviewed
Feb 21, 2023
thephez
reviewed
Feb 21, 2023
# Conflicts: # .pnp.cjs # packages/dashmate/src/commands/setup.js # packages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js # yarn.lock
# Conflicts: # .pnp.cjs # yarn.lock
thephez
reviewed
Mar 27, 2023
thephez
left a comment
thephez
left a comment
Collaborator
There was a problem hiding this comment.
👍 A few more comments/suggestions to consider
Collaborator
|
@strophy 🙈 Sorry, I see you just acked 2 minutes ago. They're only suggestions so do as you see fit 🙂 |
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
strophy
previously approved these changes
Mar 27, 2023
shuplenkov
previously approved these changes
Mar 27, 2023
shumkov
dismissed stale reviews from shuplenkov, thephez, and strophy
via
March 28, 2023 05:35
302edbb
shuplenkov
approved these changes
Mar 28, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Core 19 goes with HPMN and we need to provide a good UX to start any types of nodes for mainnet and testnet
What was done?
setupcommandsetupcommand UXHow Has This Been Tested?
Manually
Breaking Changes
Checklist:
For repository code-owners and collaborators only