fix(dashmate): testnet node fails to setup with funding key#838
Closed
pshenmic wants to merge 3 commits into
Closed
fix(dashmate): testnet node fails to setup with funding key#838pshenmic wants to merge 3 commits into
pshenmic wants to merge 3 commits into
Conversation
shumkov
requested changes
Mar 22, 2023
| */ | ||
| async function importPrivateKey(coreService, privateKey) { | ||
| return coreService.getRpcClient().importPrivKey(privateKey, { wallet: 'main' }); | ||
| async function importPrivateKey(coreService, privateKey, walletName = null) { |
Collaborator
Author
There was a problem hiding this comment.
I am not sure about that. We only invoke importPrivateKey() inside registerMasternodeTask, which is currently only used during setup local phase. ConfigureCoreTask are creating wallet separately before executing registerMasternodeTask, and its obvious that we should use main. But when registerMasternodeTask are invoked via command, it does not have any predefined created wallets, so it will fail with error that it cannot find such wallet.
Should we move createwallet rpc command inside registerMastenodeTask?
Collaborator
|
The setup command doesn't accept the funding key and any other options anymore #794 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Testnet node setup fails when funding key is passed to the testnet node
#817
What was done?
Empty masternode operator private key while register node
How Has This Been Tested?
Locally
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only