chore(key-wallet): loosen wallet recovery perf threshold to 70ms

[QuantumExplorer]

Summary

• `test_wallet_recovery_performance` asserts a <50ms average over 10 iterations. On shared GitHub-hosted Ubuntu runners, the observed averages land in the 50-60ms range, with max samples up to ~70ms (see PR #662 CI run — "Average time: 54.977162ms", max 70.018ms). The test is gating on runner speed rather than code performance — flakes with no regression to investigate.
• Bumps the avg threshold to 70ms and updates the accompanying `println!` + assert message.

Not a code-perf change, just a CI-stability fix. If real regressions land, the test will still catch them (a regression that pushed averages above 70ms on the same hardware would be significant).

Test plan

• Existing observed averages (50-60ms) comfortably below new 70ms threshold
• Ubuntu CI runs green on this PR

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Adjusted wallet recovery performance test thresholds to improve test reliability across different CI environments.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1d3699ad-a0c0-4a51-91aa-e6f32f0a07bd

📥 Commits

Reviewing files that changed from the base of the PR and between 5f40cf8 and 04e032f.

📒 Files selected for processing (1)

• key-wallet/src/tests/performance_tests.rs

---

📝 Walkthrough

Walkthrough

Updated the wallet recovery performance test acceptance criteria from < 50ms to < 70ms, including corresponding assertion messages and added inline comments documenting the threshold rationale for slower CI runners.

Changes

Cohort / File(s)	Summary
Performance Test Update key-wallet/src/tests/performance_tests.rs	Relaxed wallet recovery performance threshold from < 50ms to < 70ms. Updated assertion failure message and added inline comments clarifying the threshold is sized for slowest CI runners with expected average range documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐰 A faster hop, or slower still?
We tune the test with thoughtful will,
Seventy milliseconds fair,
For runners slow with patient care!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: loosening the wallet recovery performance test threshold from 50ms to 70ms.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/wallet-recovery-perf-threshold-70ms

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.12%. Comparing base (79484ae) to head (21e1a19).
⚠️ Report is 2 commits behind head on v0.42-dev.

Additional details and impacted files

@@            Coverage Diff             @@
##           v0.42-dev     #663   +/-   ##
==========================================
  Coverage      68.12%   68.12%           
==========================================
  Files            319      319           
  Lines          67660    67660           
==========================================
  Hits           46093    46093           
  Misses         21567    21567           

Flag	Coverage Δ
core	75.52% <ø> (ø)
ffi	38.27% <ø> (ø)
rpc	20.00% <ø> (ø)
spv	85.84% <ø> (ø)
wallet	68.05% <ø> (ø)
see 6 files with indirect coverage changes