Skip to content

chore(key-wallet): loosen wallet recovery perf threshold to 70ms #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdustinface merged 2 commits into from
Apr 20, 2026
Merged

chore(key-wallet): loosen wallet recovery perf threshold to 70ms #663

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e032f
chore(key-wallet): loosen wallet recovery perf threshold to 70ms
QuantumExplorer Apr 19, 2026
21e1a19
Merge branch 'v0.42-dev' into chore/wallet-recovery-perf-threshold-70ms
xdustinface Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions key-wallet/src/tests/performance_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,16 @@ fn test_wallet_recovery_performance() {
println!("Total time for {} iterations: {:?}", iterations, metrics.total_time);
println!("Operations per second: {:.2}", metrics.ops_per_second);
println!("Min/Max times: {:?} / {:?}", metrics.min_time, metrics.max_time);
println!("Expected: < 50ms per recovery");
println!("Expected: < 70ms per recovery");
println!("===================================\n");

// Assert performance requirements
// Assert performance requirements. Threshold sized for the slowest
// CI runners (shared GitHub-hosted Ubuntu), where observed averages
// land in the 50-60ms range. 70ms gives headroom without hiding real
// regressions.
assert!(
metrics.avg_time < Duration::from_millis(50),
"Wallet recovery too slow: avg {:?}, expected < 50ms",
metrics.avg_time < Duration::from_millis(70),
"Wallet recovery too slow: avg {:?}, expected < 70ms",
metrics.avg_time
);
}
Expand Down
Loading