WIP: Implement join reordering of fact-dimension joins#950
Closed
andygrove wants to merge 32 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #950 +/- ##
==========================================
+ Coverage 76.62% 77.63% +1.01%
==========================================
Files 73 75 +2
Lines 4115 4230 +115
Branches 751 770 +19
==========================================
+ Hits 3153 3284 +131
+ Misses 792 774 -18
- Partials 170 172 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andygrove
changed the title
3 tasks
sarahyurick
added a commit
to sarahyurick/dask-sql
that referenced
this pull request
Feb 2, 2023
charlesbluca
added a commit
that referenced
this pull request
Apr 5, 2023
* add changes from #950 * add changes from apache/datafusion#4620 * minor changes * save df 17 progress * better save * fix optimize_children logic * add FIXMEs * style fix * remove bracket * add warning * address reviews * Apply suggestions from code review Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com> * add more suggestions --------- Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new logical plan optimization rule based on the paper Improving Join Reordering for Large Scale Distributed Computing
Builds on #949