Skip to content

Alternative way of listening on all interfaces for the bokeh server#135

Merged
guillaumeeb merged 3 commits into
dask:masterfrom
lesteve:bokeh-listen-on-all-interfaces
Aug 24, 2018
Merged

Alternative way of listening on all interfaces for the bokeh server#135
guillaumeeb merged 3 commits into
dask:masterfrom
lesteve:bokeh-listen-on-all-interfaces

Conversation

@lesteve

@lesteve lesteve commented Aug 22, 2018

Copy link
Copy Markdown
Member

This is an alternative to #129. Not sure which one is preferable to be completely honest ... one difference that may matter is that the scheduler does not listen on all interfaces.

This is more in the spirit of #90 (comment). I discovered through looking at the source code, that you can pass a (address, port) address fine to the diagnostics_port despite its name. Thanks to this, the bokeh diagnostics server will listen on all interfaces.

Close #126.

@guillaumeeb guillaumeeb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer this way, except I would still bind scheduler itself on all interfaces by default if no interface is provided. This should prove compatible with more network setup as default, even if only on edge cases.

@guillaumeeb

Copy link
Copy Markdown
Member

And by the way, should we update distributed keyword name? This could break other things I imagine.

@lesteve

lesteve commented Aug 22, 2018

Copy link
Copy Markdown
Member Author

I think I prefer this way, except I would still bind scheduler itself on all interfaces by default if no interface is provided. This should prove compatible with more network setup as default, even if only on edge cases.

Can you give a quick example of a cluster setup when it is useful to have the scheduler listen on all interfaces?

@guillaumeeb

Copy link
Copy Markdown
Member

No I cannot :), I just suspect it could happen. But in such a case workaround would be to pass ip kwargs when initializing cluster object. So nevermind.

@guillaumeeb

Copy link
Copy Markdown
Member

@lesteve feel free to revert your last commit, as discussed in previous comment, I don't have a strong argument for listening on all interfaces for scheduler, and if it is needed it can easily be done with kwargs.

@guillaumeeb

Copy link
Copy Markdown
Member

I will merge this once travis is OK.

@guillaumeeb guillaumeeb mentioned this pull request Aug 24, 2018
@lesteve lesteve force-pushed the bokeh-listen-on-all-interfaces branch from 03e7c60 to 3b52f26 Compare August 24, 2018 15:40
@guillaumeeb

Copy link
Copy Markdown
Member

Thought I add already pushed flake8 corrections here... Will wait to the end of Travis build to merge (if it is successful).

@guillaumeeb guillaumeeb merged commit ff4ad95 into dask:master Aug 24, 2018
@lesteve lesteve deleted the bokeh-listen-on-all-interfaces branch August 25, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants