Skip to content

Alternative way of listening on all interfaces for the bokeh server #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumeeb merged 3 commits into from
Aug 24, 2018
Merged

Alternative way of listening on all interfaces for the bokeh server #135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32992c2
Alternative way of listening on all interfaces for the bokeh server
lesteve Aug 22, 2018
3b52f26
Scheduler listens on all interfaces if interface is not specified
lesteve Aug 22, 2018
9f67015
flake8 fixes
guillaumeeb Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions dask_jobqueue/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from distributed import LocalCluster
from distributed.deploy import Cluster
from distributed.diagnostics.plugin import SchedulerPlugin
from distributed.utils import (format_bytes, parse_bytes, tmpfile)
from distributed.utils import format_bytes, parse_bytes, tmpfile, get_ip_interface

logger = logging.getLogger(__name__)
docstrings = docrep.DocstringProcessor()
Expand Down Expand Up @@ -179,8 +179,6 @@ def __init__(self,
local_directory = dask.config.get('jobqueue.%s.local-directory' % self.scheduler_name)
if extra is None:
extra = dask.config.get('jobqueue.%s.extra' % self.scheduler_name)
if interface:
extra += ' --interface %s ' % interface
if env_extra is None:
env_extra = dask.config.get('jobqueue.%s.env-extra' % self.scheduler_name)

Expand All @@ -196,11 +194,16 @@ def __init__(self,
# This attribute should be overriden
self.job_header = None

# Bind to all network addresses by default
if 'ip' not in kwargs:
kwargs['ip'] = ''

self.local_cluster = LocalCluster(n_workers=0, **kwargs)
if interface:
extra += ' --interface %s ' % interface
kwargs.setdefault('ip', get_ip_interface(interface))
else:
kwargs.setdefault('ip', '')

# Bokeh diagnostics server should listen on all interfaces
diagnostics_ip_and_port = ('', 8787)
self.local_cluster = LocalCluster(n_workers=0, diagnostics_port=diagnostics_ip_and_port,
**kwargs)

# Keep information on process, threads and memory, for use in
# subclasses
Expand Down