Skip to content

No queue arguments needed on SLURM for most clusters. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bw4sz wants to merge 3 commits into from
Closed

No queue arguments needed on SLURM for most clusters. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c41b8f
changed -A to --account
bw4sz Mar 20, 2018
1893136
Logging statements are not needed
bw4sz Mar 20, 2018
9d9eb5f
don't need queue in the dict either
bw4sz Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dask_jobqueue/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
import toolz

from distributed.utils import tmpfile, ignoring

logger = logging.getLogger(__name__)


class JobQueueCluster(object):
""" Base class to launch Dask Clusters for Job queues

Expand Down Expand Up @@ -75,6 +73,7 @@ def _calls(self, cmds):
Also logs any stderr information
"""
logger.debug("Submitting the following calls to command line")

for cmd in cmds:
logger.debug(' '.join(cmd))
procs = [subprocess.Popen(cmd,
Expand Down
8 changes: 1 addition & 7 deletions dask_jobqueue/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class SLURMCluster(JobQueueCluster):
"""
def __init__(self,
name='dask',
queue='',
project=None,
threads_per_worker=4,
processes=8,
Expand All @@ -48,9 +47,6 @@ def __init__(self,
----------
name : str
Name of worker jobs. Passed to `#SBATCH -J` option.
queue : str
Destination queue for each worker job.
Passed to `#SBATCH -p` option.
project : str
Accounting string associated with each worker job. Passed to
`#SBATCH -A` option.
Expand All @@ -77,7 +73,6 @@ def __init__(self,

#SBATCH -J %(name)s
#SBATCH -n %(processes)d
#SBATCH -p %(queue)s
#SBATCH -A %(project)s
#SBATCH -t %(walltime)s
#SBATCH -e %(name)s.err
Expand All @@ -87,7 +82,7 @@ def __init__(self,
export LANGUAGE="en_US.utf8"
export LC_ALL="en_US.utf8"

%(base_path)s/dask-worker %(scheduler)s \
"%(base_path)s/dask-worker" %(scheduler)s \
--nthreads %(threads_per_worker)d \
--nprocs %(processes)s \
--memory-limit %(memory)s \
Expand All @@ -109,7 +104,6 @@ def __init__(self,
self.cluster = LocalCluster(n_workers=0, ip=host, **kwargs)
memory = memory.replace(' ', '')
self.config = {'name': name,
'queue': queue,
'project': project,
'threads_per_worker': threads_per_worker,
'processes': processes,
Expand Down