No queue arguments needed on SLURM for most clusters.#19
Closed
bw4sz wants to merge 3 commits into
Closed
Conversation
Author
|
Confirmed works on University of Florida HPC environment. |
Member
Member
|
Yup, for consistency, we will have to refactor SLURMCluster as mentionned in #22. As for this pull request, I'm not entirely sure removing queue keyword is a good thing. Don't know Slurm, but I believe being able to specify a queue is a good thing. After #10 is merged, we may put the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed queue from default arguments. The default was empty, which caused the following arguments to be poorly parsed by SLURM. The university clusters I have worked with do not use the -p flag. Of course, it may vary by cluster. This reverts #18, which probably wasn't needed.
Closes #15