Skip to content

fix slurm config when queue not specified#21

Closed
leej3 wants to merge 1 commit into
dask:masterfrom
leej3:master
Closed

fix slurm config when queue not specified#21
leej3 wants to merge 1 commit into
dask:masterfrom
leej3:master

Conversation

@leej3

@leej3 leej3 commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

I ran into a problem when the queue is not specified. The sbatch file does not have the appropriate -p argument and the sbatch submission fails. This fixes it by getting the default slurm queue/partition.

Otherwise this tool worked really nicely. Thanks

@bocklund

Copy link
Copy Markdown

This should close the original issue of #7

If we want to implement some of those ideas, maybe we should open another issue with concrete actionable items?

@guillaumeeb

Copy link
Copy Markdown
Member

As mentioned in #19, we should wait on #10 merge. By the ways #19 and #21 kind of disagree.
As I said in #19 (comment), maybe it is better to set queue=None as a default, and if so, not add the -p option in the header of the job_script?
Will Slurm use the default queue (as PBS does) if none is specified?

@leej3

leej3 commented Mar 23, 2018

Copy link
Copy Markdown
Contributor Author

it does yes so removing it from the job script would also work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants