Skip to content

Switch from Travis to GitHub Actions#435

Merged
lesteve merged 7 commits into
dask:masterfrom
jacobtomlinson:github-actions
Jun 2, 2020
Merged

Switch from Travis to GitHub Actions#435
lesteve merged 7 commits into
dask:masterfrom
jacobtomlinson:github-actions

Conversation

@jacobtomlinson

Copy link
Copy Markdown
Member

Thought I would try a quick lift and shift from Travis to GitHub Actions.

I've reproduced exactly the Travis config in GitHub Actions config, however there's a bunch of scope for replacing some of the CI scripts with Actions from the Marketplace. Conda setup, for example, is done like this in the distributed Windows CI.

@jacobtomlinson

jacobtomlinson commented May 27, 2020

Copy link
Copy Markdown
Member Author

Ended up using the Conda setup action to get things to pass. The script wasn't working for some reason.

I also removed the -it flags from the docker commands as they were giving a bunch of warnings.

Build is now successful. https://github.com/jacobtomlinson/dask-jobqueue/actions/runs/116941234

I think checks only report here once merged.

@jacobtomlinson jacobtomlinson requested a review from lesteve May 28, 2020 09:11
@willirath

Copy link
Copy Markdown
Collaborator

Github limits free use of actions to 2,000 minutes / month / org. Is this something that could become problematic?

@jacobtomlinson

Copy link
Copy Markdown
Member Author

My understanding is that PRs count against the user's limit, not the orgs. So we only need to worry about minutes spent testing master. But that is still something to bear in mind.

I think it is also possible for Dask to fund things like this is it brings enough benefit to the community. And in my opinion better and fast CI, leads to a better contribution experience, leads to more contributions is a benefit to us. To buy another 2,000 minutes is only $16. But perhaps @mrocklin could weigh in here?

@lesteve

lesteve commented Jun 2, 2020

Copy link
Copy Markdown
Member

Github limits free use of actions to 2,000 minutes / month / org. Is this something that could become problematic?

From this:

GitHub Actions usage is free for public repositories. For private repositories, each GitHub account receives a certain amount of free minutes and storage, depending on the product used with the account.

so if I understand things correctly the 2000 minutes / month / org is only for private repositories, right?

@willirath

Copy link
Copy Markdown
Collaborator

GitHub Actions usage is free for public repositories.

Jumped right to the table. Thanks for point this out!

@lesteve

lesteve commented Jun 2, 2020

Copy link
Copy Markdown
Member

OK I am going to merge this one, I have no informed opinion on whether Travis or Github Actions is significantly better so I am going to fully trust @jacobtomlinson on this one. Thanks a lot for the PR @jacobtomlinson!

@lesteve lesteve merged commit 45eaa84 into dask:master Jun 2, 2020
@lesteve

lesteve commented Jun 2, 2020

Copy link
Copy Markdown
Member

It looks like the Github Actions CI is running on master as Jacob said: https://github.com/dask/dask-jobqueue/actions/runs/122951522

matyasselmeci added a commit to matyasselmeci/dask-jobqueue that referenced this pull request Jun 16, 2020
* master:
  Tweak name in cluster.job_script(). (dask#439)
  Switch from Travis to GitHub Actions (dask#435)
  Fix name parameters being ignored in Cluster class (dask#398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants