Tweak name in cluster.job_script().#439
Merged
Merged
Conversation
Add comment as well.
willirath
approved these changes
Jun 6, 2020
Member
Author
|
Merging this one (I mostly wanted to make sure that this would not break anything), thanks for your approval @willirath! |
matyasselmeci
added a commit
to matyasselmeci/dask-jobqueue
that referenced
this pull request
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was quite surprised by this in #196 (comment) at one point and forgot that
cluster.job_script()is not exactly the same script that is submitted for each submission script that runsdask-worker.Also dummy-name is easier to grep than name, so easier to reach the comment as well next time I forget about this and need to be remembered.