Skip to content

use dask.utils.tmpfile as distributed.utils.tmpfile was deprecated #529

Merged
guillaumeeb merged 1 commit into
dask:mainfrom
riedel:use_dask_utils_temporary_528
Nov 1, 2021
Merged

use dask.utils.tmpfile as distributed.utils.tmpfile was deprecated #529
guillaumeeb merged 1 commit into
dask:mainfrom
riedel:use_dask_utils_temporary_528

Conversation

@riedel

@riedel riedel commented Oct 30, 2021

Copy link
Copy Markdown
Member

Fixes #528

@riedel riedel changed the title use dask.utils.temporary as distributed.utils.temporary was deprecated use dask.utils.tmpfile as distributed.utils.tmpfile was deprecated Oct 30, 2021
@riedel riedel force-pushed the use_dask_utils_temporary_528 branch from 20a2e14 to 4006fa4 Compare October 30, 2021 09:50

@andersy005 andersy005 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏽

@andersy005

Copy link
Copy Markdown
Member

Do we need to update the version requirement for dask or does this work with our existing version requirement?

@riedel

riedel commented Oct 30, 2021

Copy link
Copy Markdown
Member Author

Do we need to update the version requirement for dask or does this work with our existing version requirement?

Should be OK:
https://github.com/dask/dask/blob/c48623bcd6e5fd7699b15c0e611ee38fff167ff6/dask/utils.py#L103-L118

@riedel

riedel commented Oct 30, 2021

Copy link
Copy Markdown
Member Author

@andersy005 : you might have made a point, but it was not me: #530

@guillaumeeb guillaumeeb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @riedel for all your involvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distributed.utils.tmpfile used in core.py to create the jobscript is deprecated

3 participants