Skip to content

add functions for testing in cluster specific enviroments#532

Closed
riedel wants to merge 1 commit into
dask:mainfrom
riedel:really_test_security
Closed

add functions for testing in cluster specific enviroments#532
riedel wants to merge 1 commit into
dask:mainfrom
riedel:really_test_security

Conversation

@riedel

@riedel riedel commented Oct 31, 2021

Copy link
Copy Markdown
Member

instead of testing different scheduler classes with the same test code on a local system, actually also allow iterating through different CIs

add test for security inside ci as an example

add test for security inside ci
@riedel

riedel commented Oct 31, 2021

Copy link
Copy Markdown
Member Author

As expected htcondor fails here because actually no shared filesystem is configured...

guess this is the same for slurm

@riedel

riedel commented Nov 1, 2021

Copy link
Copy Markdown
Member Author

I actually just noticed that this is a different take at #353 without breaking much. Would it make sense to move the helper functions a central place and rather start rebuild things more iteratively. One test by one. The merged pytest -E makes this rather straight forward without overtesting.

@riedel

riedel commented Nov 1, 2021

Copy link
Copy Markdown
Member Author

If this is seriously considered for merging I would mark the failing ones as xfail. Any feedback welcome! I think this is really needed to efficiently test security across all schedulers.

@riedel

riedel commented Nov 7, 2021

Copy link
Copy Markdown
Member Author

close in favour of general overhaul in #533

@riedel riedel closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all job schedulers CI Continuous Integration tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant