rewrite testing across clusters using fixtures#533
Merged
guillaumeeb merged 5 commits intoNov 24, 2021
Conversation
xfail security align LocalCluster api for unified testing move job unrelated test functions from test_job and to test_jobqueue_core for now
Member
Author
|
IMHO this makes testing alot easier to read. It also reduces the lines of code necessary considerably. |
riedel
changed the title
move htcondor defaults to fixture revert move of docstring check (to make diff minimal) test_job now uses fixture
riedel
commented
Nov 7, 2021
riedel
left a comment
riedel
left a comment
Member
Author
There was a problem hiding this comment.
I tried to add a few explanations
This was referenced Nov 7, 2021
add link to issue in xfail
riedel
force-pushed
the
rewrite_env_testing_using_fixtures
branch
from
34fffe4 to
7656084
Compare
riedel
commented
Nov 16, 2021
guillaumeeb
reviewed
Nov 21, 2021
guillaumeeb
left a comment
guillaumeeb
left a comment
Member
There was a problem hiding this comment.
This looks really neat!!
I just have a few questions and clarification, and a bit reluctance changing the submission script template.
Otherwise this would be a much welcomed change!
document fixtures remove leftovers and inconsistencies rename xfail_ci to xfail_env for consistency
Member
Author
|
@guillaumeeb , thanks for reviewing and catching some issues, I tried to incorporate them. I removed the changes to local.py and core.py as they are debatable and can go in a seperate PR . Hope no concerns are left. Added some docstrings to the fixtures. |
riedel
commented
Nov 22, 2021
riedel
left a comment
riedel
left a comment
Member
Author
There was a problem hiding this comment.
all your comments should be addressed ?!?
Member
|
Thanks once more @riedel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please not that this conflicts and is not in sync with @lesteve's #353 . But it might be easier now since #521 was "fixed" .