Use released version of distributed.#54
Conversation
At the time of writing you need to have both dask and distributed master. Also this seems like a better idea to test against lreleased version of distributed in our CI.
|
See also #48 (comment) |
|
So this seems to be in conflict with current @mrocklin proposal in #48. I'm not against having dependency against master version of distributed or dask for now, as dask-jobqueue is quite new. In the long run, I would recommend as @lesteve to be dependant and test against released versions. |
|
I think that this PR is correct and that we should go ahead and merge regardless of what happens in #48 . That discussion could take a while and it shouldn't blog progress in the meantime. Getting in CI for PBS seems higher priority to me than the config changes. That being said, I'd love it if people would try out the configuration system and see if it is in an improvement or not. The more quickly we get feedback like this from downstream projects like dask-jobqueue and dask-kubernetes (see equivalent PR there: dask/dask-kubernetes#75) the more quickly we can solidify things into a release. |
|
And @lesteve, with this fix don't you run into this kind of failure: https://travis-ci.org/dask/dask-jobqueue/jobs/372327569. |
The latest distributed release is 4 days old. I am betting on the fact that the bug-fix that was in master when you were working on #47 has been included in the release. |
You are absolutely right. |
guillaumeeb
left a comment
There was a problem hiding this comment.
I think we should merge this one.
At the time of writing you need to have both dask and distributed master because of the config overhaul (dask/distributed#1948 and dask/dask#3432). If you only have distributed from master you'll have an error like this:
Also this seems like a better idea to test against released version of distributed
in our CI, as the end user is very likely going to be using a released version of distributed.
Given that there was a relase of distributed 4 days ago, I reckon this is recent enough. We can always revert to testing against distributed if we need bleeding-edge features but I would rather fix master first.