Slurm CI implementation#57
Merged
Merged
Conversation
Slurm cluster is starting well More representative slurm nodes Working slurm test on laptop Fix sge remains
guillaumeeb
force-pushed
the
slurm_docker_ci
branch
from
396923e to
53f327e
Compare
Member
Author
|
Seems to be okay for SLURM. Need to wait for #54 merge for sge failures. |
Member
|
Thanks for your continued work on this. I’m personally fine with you
merging your own ci prs to speed this process up. We can be a bit more
particular on the api changes.
|
Member
Author
I'm good with this as long as there has been some reviews (which is the case for #47), however, I don't think I've got the rights on this repo to do it. |
Member
Author
|
I've also fixed PBS ci in the last commit, which was broken as Sge in #54. |
Member
|
This looks good to me. Merging. @guillaumeeb I've also sent out an invitation giving you write permissions to this repository. Thank you for all of your work here, this project wouldn't be nearly as far along without you. |
Member
Author
|
Thanks, it's a pleasure to contribute to the Dask/Pangeo effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42.
Tests working on laptop, we'll see with Travis.
Will need to be slightly reworked after #47 is merged.