Fix deserialization of bytes chunks larger than 64MB#2637
Merged
Conversation
4 tasks
Member
Author
|
I'm still writing a test for this, please hold on to merging until then. |
mrocklin
reviewed
Apr 29, 2019
Member
|
Thanks for the fix @pentschev . I have a small suggestion, but am +1 regardless. You should be able to press the "commit suggestion" button. |
Co-Authored-By: pentschev <peter@entschev.com>
Member
Author
|
@mrocklin the failure doesn't seem to be related to this PR. |
Member
|
I actually don't see a failure at all. Regardless, merging. |
Member
Author
|
Thanks @mrocklin ! |
Member
|
Thanks for finding and resolving the bug @pentschev
…On Mon, Apr 29, 2019 at 2:33 PM Peter Andreas Entschev < ***@***.***> wrote:
Thanks @mrocklin <https://github.com/mrocklin> !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2637 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACKZTCRRVLUROEIRDHYFADPS5ESLANCNFSM4HJEE2TQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When chunks of
bytesare larger than 64MB they get split into multiple 64MB frames within the serializer. When_deserialize_bytes()returns only the first frame, it truncates the object and it's unable to deserialize it. The solution is simply to join all the frames.