Skip to content

Fix deserialization of bytes chunks larger than 64MB #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrocklin merged 3 commits into from
Apr 29, 2019
Merged

Fix deserialization of bytes chunks larger than 64MB #2637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b81cb90
Join frames on _deserialize_bytes()
pentschev Apr 29, 2019
ccb8861
Test for deserialization of bytes larger than 64MB
pentschev Apr 29, 2019
b48c185
Reduce test_serialize_bytes large data sample to decrease runtime
mrocklin Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion distributed/protocol/serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def _serialize_bytes(obj):

@dask_deserialize.register((bytes, bytearray))
def _deserialize_bytes(header, frames):
return frames[0]
return b"".join(frames)


#########################
Expand Down
2 changes: 1 addition & 1 deletion distributed/protocol/tests/test_serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def test_empty_loads_deep():


def test_serialize_bytes():
for x in [1, "abc", np.arange(5)]:
for x in [1, "abc", np.arange(5), b"ab" * int(40e6)]:
b = serialize_bytes(x)
assert isinstance(b, bytes)
y = deserialize_bytes(b)
Expand Down