Skip to content

WorkerProcess blocks on kill if still starting #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crusaderky merged 2 commits into from
Dec 21, 2022
Merged

WorkerProcess blocks on kill if still starting #7424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acce951
WorkerPorcess blocks on kill if still starting
mrocklin Dec 20, 2022
0d58913
Merge branch 'main' of github.com:dask/distributed into process-wait-…
mrocklin Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion distributed/nanny.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,8 +796,13 @@ async def kill(
if self.status == Status.stopping:
await self.stopped.wait()
return
# If the process is not properly up it will not watch the closing queue
# and we may end up leaking this process
# Therefore wait for it to be properly started before killing it
if self.status == Status.starting:
await self.running.wait()

assert self.status in (
Status.starting,
Status.running,
Status.failed, # process failed to start, but hasn't been joined yet
), self.status
Expand Down