Skip to content

WorkerProcess blocks on kill if still starting#7424

Merged
crusaderky merged 2 commits into
dask:mainfrom
mrocklin:process-wait-started-before-close
Dec 21, 2022
Merged

WorkerProcess blocks on kill if still starting#7424
crusaderky merged 2 commits into
dask:mainfrom
mrocklin:process-wait-started-before-close

Conversation

@mrocklin

@mrocklin mrocklin commented Dec 20, 2022

Copy link
Copy Markdown
Member

See #6311

This is a commit that @fjetter already wrote, but didn't get put into main. I'm just putting it up here to see if it fixes problems. It seems to do so.

@mrocklin mrocklin force-pushed the process-wait-started-before-close branch from 44f32f2 to acce951 Compare December 20, 2022 15:44
@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

  22 files  ±0  22 suites  ±0   9m 30s ⏱️ -3s
  13 tests ±0    0 ✔️ ±0    10 💤 ±0  0 ±0    3 🔥 ±0 
268 runs  ±0    0 ✔️ ±0  202 💤 ±0  0 ±0  66 🔥 ±0 

For more details on these errors, see this check.

Results for commit acce951. ± Comparison against base commit 73e0668.

@mrocklin mrocklin changed the title WorkerPorcess blocks on kill if still starting WorkerProcess blocks on kill if still starting Dec 20, 2022
@mrocklin

Copy link
Copy Markdown
Member Author

Anecdotally this seems to be a very good commit to have. CI is decently happy and I've been seeing this failure occur frequently. @crusaderky do you have time to review tomorrow?

@mrocklin

Copy link
Copy Markdown
Member Author

CI is fully green. (one yellow, but it appears to have actually gone through everything correctly and happily when you investigate)

@mrocklin

Copy link
Copy Markdown
Member Author

xref #7323 where I suspect this commit originally came from

@mrocklin

Copy link
Copy Markdown
Member Author

Two failures in test_semaphore

One failure in dashboard test_simple (maybe already fixed in #7426 )

@mrocklin

Copy link
Copy Markdown
Member Author

Merging later today if there are no further comments

@crusaderky crusaderky merged commit 9384a4f into dask:main Dec 21, 2022
@mrocklin mrocklin deleted the process-wait-started-before-close branch December 21, 2022 16:56
@mrocklin

Copy link
Copy Markdown
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants