Skip to content

Add resources for mlflow models and experiments#263

Merged
pietern merged 2 commits intomainfrom
mlflow-resources
Mar 20, 2023
Merged

Add resources for mlflow models and experiments#263
pietern merged 2 commits intomainfrom
mlflow-resources

Conversation

@pietern
Copy link
Copy Markdown
Contributor

@pietern pietern commented Mar 20, 2023

Manually confirmed that both can be deployed.

@pietern pietern requested a review from shreyas-goenka March 20, 2023 14:45
Copy link
Copy Markdown
Contributor

@shreyas-goenka shreyas-goenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just one comment

@pietern pietern merged commit 58563b1 into main Mar 20, 2023
@pietern pietern deleted the mlflow-resources branch March 20, 2023 20:28
import "github.com/databricks/databricks-sdk-go/service/mlflow"

type MlflowModel struct {
*mlflow.RegisteredModel
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question - any reason this uses Model and not CreateModelRequest?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall...

I thought it had to do with tags, but now I see the struct for create also includes tags, so that can't be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants