Skip to content

Update resources.models schema to match Create endpoint#2828

Merged
denik merged 7 commits intomainfrom
denik/CreateModelRequest
May 8, 2025
Merged

Update resources.models schema to match Create endpoint#2828
denik merged 7 commits intomainfrom
denik/CreateModelRequest

Conversation

@denik
Copy link
Copy Markdown
Contributor

@denik denik commented May 7, 2025

Changes

  • Use CreateModelRequest instead of Model.
  • This makes "name" required in schema and removes creation_timestamp, last_updated_timestamp, latest_versions and user_id from the allowed fields.

Why

I don't think those removed fields had any effect. Terraform is also using CreateModelRequest: https://github.com/databricks/terraform-provider-databricks/blob/main/mlflow/resource_mlflow_model.go

Tests

Existing tests.

@denik denik temporarily deployed to test-trigger-is May 7, 2025 14:07 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is May 7, 2025 14:10 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is May 7, 2025 14:40 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is May 7, 2025 14:45 — with GitHub Actions Inactive
@denik denik marked this pull request as ready for review May 7, 2025 15:09
@denik denik temporarily deployed to test-trigger-is May 7, 2025 15:09 — with GitHub Actions Inactive
@denik denik changed the title Use ml.CreateModelRequest instead of ml.Model Update resources.models schema to match Create endpoint May 7, 2025
@denik denik force-pushed the denik/CreateModelRequest branch from 88ed555 to 65043c8 Compare May 7, 2025 15:23
@denik denik temporarily deployed to test-trigger-is May 7, 2025 15:23 — with GitHub Actions Inactive
@denik denik force-pushed the denik/CreateModelRequest branch from 65043c8 to cd22d90 Compare May 7, 2025 15:23
@denik denik temporarily deployed to test-trigger-is May 7, 2025 15:24 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is May 8, 2025 12:32 — with GitHub Actions Inactive
@denik denik force-pushed the denik/CreateModelRequest branch from d06b995 to d295ab7 Compare May 8, 2025 12:40
@denik denik temporarily deployed to test-trigger-is May 8, 2025 12:40 — with GitHub Actions Inactive
@denik denik changed the base branch from main to denik/embed-struct-not-ptr May 8, 2025 13:03
@denik denik force-pushed the denik/embed-struct-not-ptr branch from a1add45 to 9fa0be8 Compare May 8, 2025 13:05
Base automatically changed from denik/embed-struct-not-ptr to main May 8, 2025 13:08
@denik denik force-pushed the denik/CreateModelRequest branch from d295ab7 to 3c3eeb3 Compare May 8, 2025 13:09
@denik denik temporarily deployed to test-trigger-is May 8, 2025 13:09 — with GitHub Actions Inactive
@denik denik merged commit f686d89 into main May 8, 2025
9 of 10 checks passed
@denik denik deleted the denik/CreateModelRequest branch May 8, 2025 13:37
denik added a commit that referenced this pull request May 9, 2025
@denik denik mentioned this pull request May 9, 2025
denik added a commit that referenced this pull request May 9, 2025
deco-sdk-tagging bot added a commit that referenced this pull request May 14, 2025
## Release v0.252.0

### Dependency updates
* Upgraded Go SDK to 0.69.0 ([#2867](#2867))
* Upgraded to TF provider 1.79.0 ([#2869](#2869))

### Bundles
* Remove unused fields from resources.models schema: creation\_timestamp, last\_updated\_timestamp, latest\_versions and user\_id. Using them now raises a warning ([#2828](#2828)).
* Preserve folder structure for app source code in bundle generate ([#2848](#2848))
* Fix normalising requirements file path in dependencies section ([#2861](#2861))
* Fix default-python template not to add environments when serverless=yes and include\_python=no ([#2866](#2866))
* Fix handling of Unicode characters in Python support ([#2873](#2873))
* Add support for secret scopes in DABs ([#2744](#2744))
* Make `artifacts.*.type` optional in bundle JSON schema ([#2881](#2881))
* Fix support for `spot_bid_max_price` field in Python support ([#2883](#2883))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants