Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
andrewnester
approved these changes
May 13, 2025
andrewnester
approved these changes
May 13, 2025
NEXT_CHANGELOG.md
Outdated
|
|
||
| ### Bundles | ||
| * Removed unused fields from resources.models schema: creation\_timestamp, last\_updated\_timestamp, latest\_versions and user\_id. Using them now raises a warning. | ||
| * Fixed default-python template for case when serverless=yes and include\_python=no. ([#2866](https://github.com/databricks/cli/pull/2866)) |
Contributor
There was a problem hiding this comment.
Suggested change
| * Fixed default-python template for case when serverless=yes and include\_python=no. ([#2866](https://github.com/databricks/cli/pull/2866)) | |
| * Do not add environments section in default-python templates if there is no python_wheel_task section ([#2866](https://github.com/databricks/cli/pull/2866)) |
Contributor
Author
There was a problem hiding this comment.
I prefer original - it tells users what feature is broken(default template with serverless=yes & include_python=no). The stuff about environments and python_wheel_task is impl details.
denik
force-pushed
the
denik/serverless-remove-environments
branch
from
c3d469f to
6d45a30
Compare
denik
changed the title
This reverts commit 89e5b68.
denik
changed the title
lennartkats-db
approved these changes
May 13, 2025
anton-107
pushed a commit
that referenced
this pull request
May 14, 2025
…es and include_python=no (#2866) ## Changes Do not add environments section in default-python templates if there is no python_wheel_task section. ## Why Since it's python_wheel_task that triggers implicit artifact and wheel creation, environment fails with the error when resolving `./dist/*.whl` pattern. ## Tests New acceptance test that extensively deploys all possible combinations of default-python template. On main branch this test fails for combinations with serverless=yes include_python=no.
deco-sdk-tagging bot
added a commit
that referenced
this pull request
May 14, 2025
## Release v0.252.0 ### Dependency updates * Upgraded Go SDK to 0.69.0 ([#2867](#2867)) * Upgraded to TF provider 1.79.0 ([#2869](#2869)) ### Bundles * Remove unused fields from resources.models schema: creation\_timestamp, last\_updated\_timestamp, latest\_versions and user\_id. Using them now raises a warning ([#2828](#2828)). * Preserve folder structure for app source code in bundle generate ([#2848](#2848)) * Fix normalising requirements file path in dependencies section ([#2861](#2861)) * Fix default-python template not to add environments when serverless=yes and include\_python=no ([#2866](#2866)) * Fix handling of Unicode characters in Python support ([#2873](#2873)) * Add support for secret scopes in DABs ([#2744](#2744)) * Make `artifacts.*.type` optional in bundle JSON schema ([#2881](#2881)) * Fix support for `spot_bid_max_price` field in Python support ([#2883](#2883))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Do not add environments section in default-python templates if there is no python_wheel_task section.
Why
Since it's python_wheel_task that triggers implicit artifact and wheel creation, environment fails with the error when resolving
./dist/*.whlpattern.Tests
New acceptance test that extensively deploys all possible combinations of default-python template. On main branch this test fails for combinations with serverless=yes include_python=no.