Skip to content

Add PIPELINES environment variable to acceptance test framework#3170

Merged
kanterov merged 2 commits intomainfrom
pipelines-test-path
Jul 3, 2025
Merged

Add PIPELINES environment variable to acceptance test framework#3170
kanterov merged 2 commits intomainfrom
pipelines-test-path

Conversation

@alyssa-db
Copy link
Copy Markdown
Contributor

@alyssa-db alyssa-db commented Jul 2, 2025

Changes

Added a new PIPELINES environment variable to the acceptance test framework that provides a copy of the CLI binary named "pipelines". This eliminates the need to manually install the pipelines CLI in test scripts using install-pipelines-cli command.

  • Modified acceptance/acceptance_test.go to create a copy of the CLI binary as "pipelines" and set the PIPELINES environment variable
  • Added path replacement for the PIPELINES binary in test output normalization

Why

Currently, test scripts that need to use the pipelines CLI must first run install-pipelines-cli to create a local copy. This adds unnecessary complexity and setup time to tests. By providing the PIPELINES environment variable directly in the acceptance test framework, tests can immediately use $PIPELINES without any installation step, making tests simpler and faster.

This change follows the same pattern as the existing CLI environment variable, providing consistency in how test binaries are made available to test scripts.

Tests

  • All existing tests continue to pass, ensuring no regression, using new $PIPELINES

@eng-dev-ecosystem-bot
Copy link
Copy Markdown
Collaborator

eng-dev-ecosystem-bot commented Jul 2, 2025

Run: 16030845395

Env ✅‌pass 🙈‌skip
✅‌ aws linux 297 373
✅‌ aws windows 298 372
✅‌ aws-ucws linux 399 273
✅‌ aws-ucws windows 400 272
✅‌ azure linux 297 372
✅‌ azure windows 298 371
✅‌ azure-ucws linux 401 270
✅‌ azure-ucws windows 402 269
✅‌ gcp linux 296 374
✅‌ gcp windows 297 373

Copy link
Copy Markdown
Collaborator

@kanterov kanterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewnester can you please take a look? I know you had reservations against it, for me, it makes total sense

@alyssa-db alyssa-db temporarily deployed to test-trigger-is July 2, 2025 16:39 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@jefferycheng1 jefferycheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this helps cleanup our tests a lot

@kanterov kanterov added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit f35e409 Jul 3, 2025
13 checks passed
@kanterov kanterov deleted the pipelines-test-path branch July 3, 2025 08:43
denik pushed a commit that referenced this pull request Jan 21, 2026
## Changes

This PR removes the unused standalone pipelines CLI entrypoint
infrastructure. The ability to invoke the CLI binary as `pipelines`
(instead of `databricks`) was never released and is no longer needed.
All pipelines functionality remains available through `databricks
pipelines` commands.

PRs that added this:
- #3009
- #3114
- #3170
- #3177
- #3221

## Tests

Updated acceptance tests.

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants