Fix bundle plan to not create workspace objects or upload the files#3442
Merged
andrewnester merged 17 commits intomainfrom Sep 1, 2025
Merged
Fix bundle plan to not create workspace objects or upload the files#3442andrewnester merged 17 commits intomainfrom
bundle plan to not create workspace objects or upload the files#3442andrewnester merged 17 commits intomainfrom
Conversation
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
commented
Aug 19, 2025
andrewnester
commented
Aug 19, 2025
| terraform.CheckRunningResource(), | ||
|
|
||
| // artifacts.CleanUp() is there because I'm not sure if it's safe to move to later stage. | ||
| artifacts.CleanUp(), |
Contributor
Author
There was a problem hiding this comment.
We call CleanUp later now, but before doing libraries.Upload. This appears to be safe because we do not rely on the remote artifacts folder anywhere before we call libraries.Upload(),
Collaborator
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Aug 19, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Aug 20, 2025
denik
reviewed
Aug 20, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Aug 20, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
commented
Aug 20, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
) ## Changes Convert artifacts_test and upload_test into acceptance tests ## Why Needed for #3442 <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Aug 26, 2025
denik
reviewed
Aug 26, 2025
denik
reviewed
Aug 26, 2025
| @@ -0,0 +1,20 @@ | |||
| bundle: | |||
Contributor
There was a problem hiding this comment.
For more comprehensive test, can we add "bundle plan" + request recording to default-python various local and integration tests and check that there are no side effects there?
Contributor
Author
There was a problem hiding this comment.
I tried to include bundle plan in default-python template tests but it appeared not trivial as these are quite complex tests and adding bundle plan added additional output just as bundle.tf.json and terraform.lock files. Will follow up with these tests afterwards not to block this PR.
pietern
reviewed
Aug 26, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Sep 1, 2025
| } | ||
|
|
||
| uploadPath := path.Join(b.Config.Workspace.ArtifactPath, InternalDirName) | ||
| uploadPath = ensureWorkspaceOrVolumesPrefix(uploadPath) |
Contributor
There was a problem hiding this comment.
Could you add a comment why this is needed? Unclear why we would be missing prefix now.
Contributor
Author
There was a problem hiding this comment.
Added, it's not that we miss it now, I just moved it from the other place to here, but I added the comment to the function
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refactored
deployPrepareto make it non-mutative. Moved artifact folder cleanup and libraries upload touploadLibraries, which is only used by deploy.Why
This makes
bundle plannon-mutative and safe to use to preview bundle changes.Tests
Added acceptance test