acc: Convert artifacts_test and upload_test into acceptance tests#3477
Merged
andrewnester merged 3 commits intomainfrom Aug 26, 2025
Merged
acc: Convert artifacts_test and upload_test into acceptance tests#3477andrewnester merged 3 commits intomainfrom
andrewnester merged 3 commits intomainfrom
Conversation
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
denik
reviewed
Aug 25, 2025
| @@ -0,0 +1 @@ | |||
| *.whl | |||
Contributor
There was a problem hiding this comment.
what's the purpose of this .gitignore, how does it affect this test?
Why does it upload anything? Because libraries setting overrides gitignore?
Contributor
Author
There was a problem hiding this comment.
Left over from the other iteration, we indeed don't need it here
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Aug 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Convert artifacts_test and upload_test into acceptance tests
Why
Needed for #3442