Skip to content

Update the lakeflow-pipelines template according to the latest Lakeflow conventions#3558

Merged
lennartkats-db merged 10 commits intomainfrom
lakeflow-default-python-v0
Sep 23, 2025
Merged

Update the lakeflow-pipelines template according to the latest Lakeflow conventions#3558
lennartkats-db merged 10 commits intomainfrom
lakeflow-default-python-v0

Conversation

@lennartkats-db
Copy link
Copy Markdown
Contributor

This adds a new version of the default-python template. To enable the first integration and evaluation of this template, this first pull request replaces the internal lakeflow-pipelines template. Replacing default-python will be the next milestone.

Changes

  • Update default-python to follow the Lakeflow conventions (per-pipeline sources go into resources/; shared sources go into (lib/)
  • Adapt this template so it can first be used in place of the lakeflow-pipelines template (this required disabling some of the template questions and components)

Why

Lakeflow comes with new conventions that emphasize modularity. This PR represents an initial milestone towards updating the DABs default-python template. default-sql will follow in a later milestone.

Tests

Existing tests were updated.

@lennartkats-db lennartkats-db changed the title Add a Lakeflow-friendly default-python template Add a Lakeflow-friendly DABs template Sep 8, 2025
@eng-dev-ecosystem-bot
Copy link
Copy Markdown
Collaborator

eng-dev-ecosystem-bot commented Sep 8, 2025

Run: 17893981483

Env ✅​pass 🔄​flaky 🙈​skip
✅​ aws linux 311 528
✅​ aws windows 312 527
🔄​ aws-ucws linux 414 9 426
🔄​ aws-ucws windows 415 9 425
✅​ azure linux 311 527
✅​ azure windows 312 526
🔄​ azure-ucws linux 419 4 425
🔄​ azure-ucws windows 416 8 424
✅​ gcp linux 310 529
✅​ gcp windows 311 528
10 failing tests:
Test Name aws-ucws linux aws-ucws windows azure-ucws linux azure-ucws windows
TestAccept ✅​pass ✅​pass 🔄​flaky ✅​pass
TestAccept/bundle/deploy/dashboard/detect-change 🔄​flaky 🔄​flaky ✅​pass 🔄​flaky
TestAccept/bundle/deploy/dashboard/generate_inplace 🔄​flaky 🔄​flaky ✅​pass 🔄​flaky
TestAccept/bundle/deploy/dashboard/nested-folders 🔄​flaky 🔄​flaky ✅​pass 🔄​flaky
TestAccept/bundle/deploy/dashboard/simple 🔄​flaky 🔄​flaky ✅​pass 🔄​flaky
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root 🔄​flaky 🔄​flaky ✅​pass 🔄​flaky
TestAccept/bundle/deploy/dashboard/simple_syncroot 🔄​flaky 🔄​flaky ✅​pass 🔄​flaky
TestAccept/bundle/deployment/bind/dashboard 🔄​flaky 🔄​flaky 🔄​flaky 🔄​flaky
TestAccept/bundle/deployment/bind/dashboard/recreation 🔄​flaky 🔄​flaky 🔄​flaky ✅​pass
TestDashboardAssumptions_WorkspaceImport 🔄​flaky 🔄​flaky 🔄​flaky 🔄​flaky

Copy link
Copy Markdown
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this end-to-end yet because of the missing pyproject.toml.

Though this is unfortunately inconsistent with the one from Black
@lennartkats-db lennartkats-db changed the title Add a Lakeflow-friendly DABs template Update the lakeflow-pipelines template according to the latest Lakeflow conventions Sep 16, 2025
Copy link
Copy Markdown
Contributor

@fjakobs fjakobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the proposed changes but let's make sure to address @andersrexdb 's comment.

@lennartkats-db lennartkats-db added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit a6398a3 Sep 23, 2025
13 checks passed
@lennartkats-db lennartkats-db deleted the lakeflow-default-python-v0 branch September 23, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants