Added new Lakeflow Pipelines support for bundle generate#3568
Merged
andrewnester merged 9 commits intomainfrom Sep 17, 2025
Merged
Added new Lakeflow Pipelines support for bundle generate#3568andrewnester merged 9 commits intomainfrom
bundle generate#3568andrewnester merged 9 commits intomainfrom
Conversation
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| name: lakeflow-pipeline | ||
| libraries: | ||
| - glob: | ||
| include: ../pipeline/transformations/** |
Contributor
There was a problem hiding this comment.
This might be something for a followup, but pipeline source code should be in the same folder as the pipeline definiton for Lakeflow. So this should always say transformations/**. See also #3558.
Contributor
Author
There was a problem hiding this comment.
This is configured by use of --config-dir and --source-dir flags in bundle generate command and for this specific test I set them up in such a way that it also tests that all complex relative paths are resolved correctly.
This is not an example of how configuration should look like though
| include: ../pipeline/transformations/** | ||
| - glob: | ||
| include: /Workspace/Users/foo@databricks.com/another/** | ||
| root_path: ../pipeline |
Contributor
There was a problem hiding this comment.
Similar to the above, the .yml file should be included in the root_path, so this should actually say . or maybe for clarity ".".
shreyas-goenka
approved these changes
Sep 15, 2025
| } | ||
|
|
||
| // Making sure the root path is relative to the config directory. | ||
| rel, err := filepath.Rel(configDir, sourceDir) |
Contributor
There was a problem hiding this comment.
Should we add an test case for this error as well?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Sep 24, 2025
## Release v0.270.0 ### Notable Changes * Add 'databricks bundle plan' command. This command shows the deployment plan for the current bundle configuration without making any changes. ([#3530](#3530)) ### Bundles * Add 'databricks bundle plan' command ([#3530](#3530)) * Add new Lakeflow Pipelines support for bundle generate ([#3568](#3568)) * Fix bundle deploy to not update permissions or grants for unbound resources ([#3642](#3642)) * Introduce new bundle variable: `${workspace.current_user.domain_friendly_name}` ([#3623](#3623)) * Improve the output of bundle run when bundle is not deployed ([#3652](#3652))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added new Lakeflow Pipelines support for
bundle generateWhy
Now if the pipeline refers to
root_pathwe download the whole content of it and rewrite any relatedlibraries.globpaths pointing to the same remote paths to the local onesTests
Added an acceptance test
Confirmed that they can be deployed here: #3578