Adding surface metadata to search_indicators endpoint#108
Merged
lucyking140 merged 19 commits intodatacommonsorg:mainfrom Oct 17, 2025
Merged
Adding surface metadata to search_indicators endpoint#108lucyking140 merged 19 commits intodatacommonsorg:mainfrom
lucyking140 merged 19 commits intodatacommonsorg:mainfrom
Conversation
…into lucysking/mcp-metadata
…into lucysking/mcp-metadata
lucyking140
had a problem deploying
to
evals-and-secrets
GitHub Actions
Failure
lucyking140
had a problem deploying
to
evals-and-secrets
GitHub Actions
Failure
lucyking140
temporarily deployed
to
evals-and-secrets
GitHub Actions
Inactive
lucyking140
temporarily deployed
to
evals-and-secrets
GitHub Actions
Inactive
keyurva
reviewed
Oct 17, 2025
| endpoint_url = f"{self.sv_search_base_url}/api/nl/search-indicators" | ||
| headers = {"Content-Type": "application/json"} | ||
| # 'x-surface' indicates to mixer that this call is coming from the MCP server | ||
| headers = { |
Contributor
There was a problem hiding this comment.
Since these headers are used at multiple places, consider extracting it into a const.
lucyking140
temporarily deployed
to
evals-and-secrets
GitHub Actions
Inactive
Contributor
Note that the |
keyurva
approved these changes
Oct 17, 2025
| # shortly to include release candidates (TODO: lucysking) | ||
| SURFACE = f"mcp-{__version__.replace('rc', '.')}" | ||
|
|
||
| # 'x-surface' indicates to mixer that this call is coming from the MCP server |
Contributor
There was a problem hiding this comment.
nit: s/mixer/DC APIs? (if we are to expand surface header's scope to non-mixer servers as well)
| # This is here temporarily because of validation in the DataCommonsClient | ||
| # that surface headers must only contain numbers, which will be updated | ||
| # shortly to include release candidates (TODO: lucysking) | ||
| SURFACE = f"mcp-{__version__.replace('rc', '.')}" |
Contributor
There was a problem hiding this comment.
nit: s/SURFACE/SURFACE_HEADER_VALUE?
| # Replaces 'rc' with '.' in a version string if present. | ||
| # This is here temporarily because of validation in the DataCommonsClient | ||
| # that surface headers must only contain numbers, which will be updated | ||
| # shortly to include release candidates (TODO: lucysking) |
Contributor
There was a problem hiding this comment.
Can we create a bug for this so it's tracked?
lucyking140
temporarily deployed
to
evals-and-secrets
GitHub Actions
Inactive
lucyking140
temporarily deployed
to
evals-and-secrets
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building from this PR that added a
surfaceto theDataCommonsClientto also pass it in on any calls made to the DC Flask API. This header is ultimately passed into Mixer and used to identify that these calls come from the MCP server.