Adding custom certificate validation #78 - #79
Conversation
Support custom certificate validation
| /// <param name="apiKey">An API key to use when making requests to the server, if required.</param> | ||
| /// <param name="useDefaultCredentials">Whether default credentials will be sent with HTTP requests; the default is <c>true</c>.</param> | ||
| public SeqApiClient(string serverUrl, string apiKey = null, bool useDefaultCredentials = true) | ||
| /// <param name="serverCertificateCustomValidationCallback">Callback for custom certificate validation</param> |
There was a problem hiding this comment.
I think that appending callback to existing HttpMessageHandler is a better solution than replacing the whole HttpMessageHandler. Because of that way no need for changing existing logic.
There was a problem hiding this comment.
I had the same thought at first, but, adding a parameter here will be a binary breaking change, which will make it harder to release, and, there are several more properties on HttpClientHandler that consumers may need to set in different situations in the future (Credentials/DefaultProxyCredentials/Proxy/PreAuthenticate, SslProtocols, MaxConnectionsPerServer) - which might cause further parameter list churn.
|
Thanks for the PR! 👍 I have a few minutes this morning, I might explore alternatives to the added parameter, I can see that it's a bit tricky to get everything lining up. |
|
@nmkryon I've submitted #80 - would appreciate your feedback. Thanks! |
Revert "Support custom certificate validation"
|
Closed in favor of #80 |
2 participants
No description provided.