Support certificate validation callbacks, proxy settings, etc. - #80
Merged
Conversation
…ntHandler, e.g. for certificate validation or proxy configuration; adds a missing IDisposable implementation on SeqConnection
|
It seems like a good option to me after the test. When we can have a package with the change? |
Member
Author
|
@nmkryon thanks for taking a look! The |
|
Thank you! |
|
When it will be possible to have the release version? |
Member
Author
|
Hi @nmkryon - normally these builds don't bake too long; we test them in a few downstream applications, and take feedback on the dev versions, for a small change like this one we should have a release in a week or two. HTH, and Happy 2020! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a configuration callback that acts on the underlying
HttpClientHandler, e.g. for certificate validation or proxy configuration.Also adds a missing
IDisposableimplementation onSeqConnection- I suspect this was omitted because of an earlier design iteration whereSeqClientwas passed intoSeqConnectionand not owned by it.Alternative to #78. CC @nmkryon