Add supports-color as optional peerDependency#709
Closed
jgierer12 wants to merge 1 commit intodebug-js:masterfrom
jgierer12:supports-color-optional-peer-dep
Closed
Add supports-color as optional peerDependency#709jgierer12 wants to merge 1 commit intodebug-js:masterfrom jgierer12:supports-color-optional-peer-dep
supports-color as optional peerDependency#709jgierer12 wants to merge 1 commit intodebug-js:masterfrom
jgierer12:supports-color-optional-peer-dep
Conversation
This is the proper way to declare this type of dependency. Note that if `peerDependenciesMeta` is not supported by the package manager and `supports-color` is not installed, a warning will be displayed.
|
Quick update that I'm currently not using this feature myself until node bundles |
Closed
Contributor
|
Note that the situation changed since the last comment. The Additionally, listing CC @Qix- |
Member
|
Published as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the proper way to declare this type of dependency.
Note that if
peerDependenciesMetais not supported by the packagemanager (yarn < 1.13 and npm) and
supports-coloris not installed, a warning will bedisplayed.
See
peerDependencies,peerDependenciesMeta.Without this, Yarn PnP to throws an error when
debugis in the dependency tree, since PnP is very strict aboutrequireing packages that aren't declared as dependencies.