Closed
Conversation
nodejs-github-bot
added
the
npm
Collaborator
gengjiawen
approved these changes
Aug 23, 2019
Member
|
This can land on or after September 5. |
Member
Contributor
@Trott Just curious about the reason for waiting until September 5 for this? (just for future reference) |
Member
We have a rule that new npm versions wait two weeks after their release before landing them in Node.js master. That caution may be outdated and we may wish to revisit it. Or maybe it is serving us well. But in either case, I post those notes because people (understandably) forget that npm PRs are handled differently from other PRs. |
This was referenced Aug 28, 2019
This was referenced Sep 5, 2019
Member
|
Superseded by #29430. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the last of the Windows regressions in 6.11.0.
Changelog:
6.11.2 (2019-08-22):
Fix a recent Windows regression, and two long-standing Windows bugs. Also, get CI running on Windows, so these things are less likely in the future.
DEPENDENCIES
9778a1b87cmd-shim@3.0.3: Fix regression where shims fail to preserve exit code (@isaacs)bf93e91d8npm-package-arg@6.1.1: Properly handle git+file: urls on Windows when a drive letter is included. (@isaacs)BUGFIXES
6cc4cc66fescape args properly on Windows Bash Despite being bash, Node.js running on windows git mingw bash still executes child processes using cmd.exe. As a result, arguments in this environment need to be escaped in the style of cmd.exe, not bash. (@isaacs)TESTS
291aba7b8make tests pass on Windows (@isaacs)fea3a023atravis: run tests on Windows as well (@isaacs)