feat: DH-20808: Add subplot_titles and title parameters to make_subplots #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_subplots Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
…ncation logic Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
…title check Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
- Rename use_existing_titles to titles_as_subtitles for clarity - Remove default value annotations from docstrings - Extract title handling logic into get_subplot_titles helper function - Move annotation and title application from unsafe_update_figure to atomic_layer - Add subplot_annotations and overall_title parameters to atomic_layer and layer - Update documentation to use simpler language (left to right, top to bottom instead of row-major) - Update all tests to use titles_as_subtitles - Simplify extract_title_from_figure to always return string Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
- Rename 'overall_title' parameter to 'title' in layer function - Remove unnecessary padding logic from get_subplot_titles (annotations are skipped for missing titles anyway) - Remove erroneous duplicate return statement in atomic_make_subplots Co-authored-by: jnumainville <10480451+jnumainville@users.noreply.github.com>
Collaborator
Author
|
Looks like this needs deephaven/deephaven-core#7596 to pass fully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added subplot_titles argument to make_subplots that can either pass in a list of new subplot titles or be set to True to maintain existing subplot titles.
Added title argument to make_subplots as well, similar to other charts.