bug: fix Agent Final Response Discarding text after newline#6574
Conversation
|
Hello @Tsadoq! Would you mind adding a test to demonstrate that your solution works? There are some indications on how to do so in the |
Done that, sorry but I completely forgot. I hope it is fine. I saw that the regex is hardcoded in the test so I added it there as well. |
|
@Tsadoq looks like you haven't run the pre-commit checks, as Black is failing. Could you do so? There are instructions in CONTRIBUTING about it. Also, we need to add a release note. This is also present in the CONTRIBUTING page, but if you need help let me know 🙂 |
Pull Request Test Coverage Report for Build 7246441017
💛 - Coveralls |
For some reason the black commit went after. Added release note :) Hopefully next time I'll be more linear in the PR |
|
Alright, looks good now 🙂 Let's wait for CI to pass and if there are no failures I'll approve and merge. |
ZanSara
left a comment
There was a problem hiding this comment.
Thank you for your contribution! 😊
Related Issues
Proposed Changes:
The agent would discard the final answer if this was distributed on multiple lines. I added a modifier in the regex so that the
.matches also newline characters.How did you test it?
One possibility is to use the agent to generate code, in this case we should see the bug and then the fix.
Notes for the reviewer
In the 2.0 I'd change this structure to pass a flag or to give a closing sequence as well.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.