Skip to content

bug: fix Agent Final Response Discarding text after newline #6574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZanSara merged 5 commits into from
Dec 18, 2023
Merged

bug: fix Agent Final Response Discarding text after newline #6574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa21d0d
Changed standard final_answer_pattern in base.py to avoid stopping ma…
Tsadoq Dec 16, 2023
dfaf340
added testing on multiline
Tsadoq Dec 18, 2023
e17e90e
added testing on final_answer_pattern for multiline matching
Tsadoq Dec 18, 2023
96f8c24
reformatting
Tsadoq Dec 18, 2023
276308d
added release note
Tsadoq Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion haystack/agents/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def __init__(
memory: Optional[Memory] = None,
prompt_parameters_resolver: Optional[Callable] = None,
max_steps: int = 8,
final_answer_pattern: str = r"Final Answer\s*:\s*(.*)",
final_answer_pattern: str = r"(?s)Final Answer\s*:\s*(.*)",
streaming: bool = True,
):
"""
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/improve-agent-final-answer-matching-21f5710035a498d8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Fixed the bug that caused the agent to discard part of final answers if they were distributed across multiple lines.
4 changes: 3 additions & 1 deletion test/agents/test_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ def test_extract_final_answer():
"Final Answer:42",
"Final Answer: ",
"Final Answer: The answer is 99 ",
"Final Answer:42 should be the answer\n\nBut it's not the only one\n\n\n\n the answer is 1948",
]
expected_answers = [
"Florida",
Expand All @@ -159,10 +160,11 @@ def test_extract_final_answer():
"42",
"",
"The answer is 99",
"42 should be the answer\n\nBut it's not the only one\n\n\n\n the answer is 1948",
]

for example, expected_answer in zip(match_examples, expected_answers):
agent_step = AgentStep(prompt_node_response=example, final_answer_pattern=r"Final Answer\s*:\s*(.*)")
agent_step = AgentStep(prompt_node_response=example, final_answer_pattern=r"(?s)Final Answer\s*:\s*(.*)")
final_answer = agent_step.final_answer(query="irrelevant")
assert final_answer["answers"][0].answer == expected_answer

Expand Down