chore(ext/node): ignore parallel/test-buffer-backing-arraybuffer.js#29505
Merged
kt3k merged 1 commit intodenoland:mainfrom May 30, 2025
Merged
chore(ext/node): ignore parallel/test-buffer-backing-arraybuffer.js#29505kt3k merged 1 commit intodenoland:mainfrom
parallel/test-buffer-backing-arraybuffer.js#29505kt3k merged 1 commit intodenoland:mainfrom
Conversation
bartlomieju
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test case checks whether the given typed arrays of various lengths are allocated in heap or not.
This case doesn't pass in Deno because we use a different value (
0) for the build optionv8_typed_array_max_size_in_heapthan Node (64). We can ignore this case for now as the difference is intentional.references: