Build with v8_typed_array_max_size_in_heap=0#1070
Merged
bnoordhuis merged 1 commit intodenoland:mainfrom Sep 18, 2022
Merged
Conversation
Ensure allocation of typed arrays and arraybuffers always goes through the embedder's ArrayBufferAllocator, otherwise small buffers get moved around by the garbage collector but embedders normally want them to have fixed addresses.
littledivy
approved these changes
Sep 17, 2022
Member
|
This should be in .gn |
Contributor
Author
|
#1075 (oh, you edited your comment...) What reads .gn? Neither rusty_v8 nor cargo_gn seem to reference it anywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure allocation of typed arrays and arraybuffers always goes through the embedder's ArrayBufferAllocator, otherwise small buffers get moved around by the garbage collector but embedders normally want them to have fixed addresses.
Refs #1068.