possible fix for #95 deprecated option UseLogin

[MrSecure]

In my testing this fixes the deprecation of the UseLogin option in more recent OpenSSH versions.
Additionally, it should detect the insecure configuration as far back as OpenSSH 3.0.2 (release notes link below state that UseLogin was NOT ENABLED by default at that time)

https://www.openssh.com/txt/release-3.0.2

[chris-rock]

Thank you @MrSecure for this improvement

[atomic111]

@MrSecure thanks for your PR, it would be nice to check for no and for nil in an describe.one block. Can you adjust this please?

[chris-rock]

Thank you @atomic111 you are right, it should be

descibe.one do
  describe sshd_config do
    its('UseLogin') { should eq 'no' }
  end
  describe sshd_config do
    its('UseLogin') { should eq nil }
  end
end

then. This prevent that all other values then nil and no are invalid, while not yes allows a lot of other values.

[chris-rock]

As requested in my comment, I think we should make the control a little bit more narrow in its allowed values

[atomic111]

@MrSecure can you please add this small change?

[artem-sidorenko]

@MrSecure @chris-rock @atomic111 we can now do it depending on the ssh version, see #110

[chris-rock]

@artem-sidorenko That would be a great solution

[artem-sidorenko]

closing this in favour of #114